Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompiled dependencies to use hive default branch. #802

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

marcoooo
Copy link
Contributor

@marcoooo marcoooo commented Jun 8, 2023

Description

Fixed the dependency wrongly pointing to ensembl-hive@main to use default branch. Caused updated a bunch of other retrieved dependencies.

Use case

Install this module.

Benefits

No more conflicts about ensembl-hive

Possible Drawbacks

Other conflicts triggered from the other updated packages.

Testing

  • Have you added/modified unit tests to test the changes?
  • If so, do the tests pass?
  • Have you run the entire test suite and no regression was detected?
  • TravisCI passed on your branch

Dependencies

If applicable, define what code dependencies were added and/or updated.

@marcoooo marcoooo requested a review from MatBarba June 8, 2023 14:01
@marcoooo marcoooo self-assigned this Jun 8, 2023
@marcoooo marcoooo requested a review from vinay-ebi June 8, 2023 14:02
@marcoooo marcoooo added the dependencies Pull requests that update a dependency file label Jun 8, 2023
@marcoooo marcoooo added this to the Ensembl 110 milestone Jun 8, 2023
Copy link
Contributor

@MatBarba MatBarba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixed my issue, thanks

@marcoooo marcoooo merged commit 3778645 into release/110 Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants