Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefSeq peptide Cleanup Fix #837

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

TamaraNaboulsi
Copy link
Member

Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion

Requirements

  • Filling out the template is required.
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Description

Fix for the RefSeq peptide files cleanup.

Use case

A bug was discovered in the process the cleans up the RefSeq peptide files (removes irrelevant data). The bug was leading to some incorrect xref information in the peptide files. This change fixes that.

Benefits

Bug fix.

Possible Drawbacks

Need to re-run the cleanup process for the currently running pipeline.

Testing

  • Have you added/modified unit tests to test the changes?
  • If so, do the tests pass?
  • Have you run the entire test suite and no regression was detected?
  • TravisCI passed on your branch

Dependencies

If applicable, define what code dependencies were added and/or updated.

@dpopleton dpopleton merged commit 3318e16 into Ensembl:release/112 Oct 19, 2023
dpopleton pushed a commit that referenced this pull request Nov 16, 2023
Co-authored-by: Tamara El Naboulsi <ten@codon-login-06.ebi.ac.uk>
@TamaraNaboulsi TamaraNaboulsi deleted the fix/refseq_cleanup branch October 14, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants