Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect input format using VEP code #1026

Merged

Conversation

nuno-agostinho
Copy link
Contributor

@nuno-agostinho nuno-agostinho commented Aug 15, 2023

  1. Update regex for input data detection based on VEP.
  2. Create new exported function for input format detection to be used by VEP, avoiding code redundancy.
  3. Accept CAID and Region input in web VEP.

Ignore alternative allele when checking VCF format

The idea of this function is to check if this format is VCF: only these columns are needed to check that.

Basically, we should not check for the alternative allele here because:

  • The valid characters for the alternative allele are constantly changing with new versions of the VCF specification
  • It only checks the first line (other lines may have issues and are ignored)
  • The regex may not be up-to-date (it already happened that we support a specific type of alternative allele but forgot to update the regex here)
  • If the alternative allele is not supported, it should be the function create_VariationFeatures() from Parse::VCF to return that issue with a warning (and not an error like detect_format(), because the format is still VCF).
  • We get user-reported issues related with the strict regex here, even though the line is fully supported by VEP

Related PRs

@nuno-agostinho nuno-agostinho changed the title Detect input format like VEP Detect input format using VEP code Aug 15, 2023
@nakib103 nakib103 self-requested a review August 15, 2023 12:26
@nakib103 nakib103 self-assigned this Aug 15, 2023
@nuno-agostinho nuno-agostinho marked this pull request as ready for review August 15, 2023 14:01
@nakib103 nakib103 added the e111 label Aug 30, 2023
Copy link
Contributor

@nakib103 nakib103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nuno, looks alright to merge!

@nakib103 nakib103 merged commit 4f13d95 into Ensembl:postreleasefix/111 Sep 5, 2023
@nuno-agostinho nuno-agostinho deleted the fix/web-vep-input-format branch September 5, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants