nsone: fix ns1-go test bugs #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
The NS1 API previously lived at github.com/bobtfish/go-nsone-api, but has moved to github.com/ns1/ns1-go. This patch: - updates the godep pin - removes the github.com/bobtfish/go-nsone-api from vendor/ - adds github.com/ns1/ns1-go to vendor/ - updates all imports to refer to the new namespace Fixes #TF-53
josephholsten
force-pushed
the
fix_nsone_tests
branch
from
7f892d4
to
ca2891e
Compare
- Clarify testAccCheckMonitoringJobDestroy error message when Monitoring Job still exists - Clarify testAccCheckZoneDestroy error message when Zone still exists - Fix testAccRecordBasic fixture to use correct zone dependency Fixes #TF-54
josephholsten
force-pushed
the
fix_nsone_tests
branch
from
ca2891e
to
32f4e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #29
Job still exists
Fixes #TF-54