-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EREGCSC-2883 Deploy CDK via Github Actions (ready for review, ignore the red X) #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ See the Django Site in action ✨ |
cgodwin1
changed the title
EREGCSC-2883 (attempt 4) Deploy CDK via Github Actions
EREGCSC-2883 Deploy CDK via Github Actions (ignore the red X)
Nov 1, 2024
cgodwin1
changed the title
EREGCSC-2883 Deploy CDK via Github Actions (ignore the red X)
EREGCSC-2883 Deploy CDK via Github Actions (ready for review, ignore the red X)
Nov 1, 2024
PhilR8
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2883
Description-
This PR implements a simple "hello world" lambda function (accessible from API Gateway) deployed via CDK alongside the standard Serverless stacks. This does not change or replace any existing stacks, only adds one additional stack per deploy.
To satisfy story number 2883, we need to deploy this code through to production and verify that the "hello world" lambda can successfully deploy via CDK in each environment: dev, val, and prod.
Once verified, manual deletion will be required (stack name is
{stage}-HelloWorldStack
, e.g.val-HelloWorldStack
). Then a PR can be created that removes the experimental code from "deploy.yml", "deploy-experimental.yml", and "remove-experimental.yml".This pull request changes...
cdk-eregs/lambda/hello_world.py
).Steps to manually verify this change...
Initial verification:
dev1464
)./hello
to the end of the URL and see that the page loads properly.Additional verification if desired (not required, I already tested this and it's not needed to satisfy the AC):
Final verification:
dev-HelloWorldStack
andval-HelloWorldStack
both exist and their API Gateways are properly configured.prod-HelloWorldStack
..github
.)cdk-eregs
directory from the main branch, although having it in main will not cause issues.