Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EREGCSC-2856 - Add text extractor CDK stack #1486

Merged
merged 10 commits into from
Nov 22, 2024
Merged

EREGCSC-2856 - Add text extractor CDK stack #1486

merged 10 commits into from
Nov 22, 2024

Conversation

addis-samtek
Copy link
Contributor

@addis-samtek addis-samtek commented Nov 19, 2024 •
edited
Loading

Resolves EREGCSC-2856

Description

This pull request changes...

  • Migrates text-extractor service from Serverless Framework to CDK TypeScript
  • Implements environment-aware deployments (dev, val, prod, ephemeral)
  • Maintains feature parity with existing CloudFormation template:
    • Docker-based Lambda function
    • SQS queue with DLQ
    • IAM roles and policies
    • VPC integration
    • CloudWatch logging

Steps to manually verify this change

Verify resources:

  • Lambda function exists with Docker image
  • SQS queues (main + DLQ) created
  • IAM roles and policies set correctly
  • VPC integration successful

Check GitHub Actions deployment:

Navigate to Actions tab
View successful deployment workflow
Verify resources created in AWS Console

@github-actions GitHub Actions
Copy link

✨ See the Django Site in action ✨

@github-actions GitHub Actions
Copy link

✨ See the Django Site in action ✨

@github-actions GitHub Actions
Copy link

✨ See the Django Site in action ✨

cgodwin1
cgodwin1 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@cgodwin1 cgodwin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@addis-samtek addis-samtek added the Needs Review This PR needs a code review label Nov 20, 2024
@github-actions GitHub Actions
Copy link

✨ See the Django Site in action ✨

@cgodwin1 cgodwin1 added Approved and removed Needs Review This PR needs a code review labels Nov 20, 2024
@brittag brittag changed the title Add text extract stack cdk EREGCSC-2856 - Add text extractor CDK stack Nov 20, 2024
@addis-samtek addis-samtek merged commit 1b736d0 into main Nov 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgodwin1 cgodwin1 cgodwin1 approved these changes

@PhilR8 PhilR8 Awaiting requested review from PhilR8 PhilR8 is a code owner

Assignees
No one assigned
Labels
Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addis-samtek @cgodwin1