fix(minor-amend-issues): fixes to the amendment stuff that got missed

Co-authored-by: tiffanyvu <tiffany.v330@gmail.com>
Enterprise-CMCS · Dec 2, 2024 · 32de0a8 · 32de0a8
1 parent 0a123ad
commit 32de0a8
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 16 deletions.
diff --git a/react-app/src/features/forms/waiver/capitated/Amendment.tsx b/react-app/src/features/forms/waiver/capitated/Amendment.tsx
@@ -125,7 +125,7 @@ export const AmendmentForm = ({ waiverId }: AmendmentFormProps) => {
       attachments={{
         faqLink: getFAQLinkForAttachments("capitated-amendment"),
       }}
-      defaultValues={{ id: "", waiverNumber: waiverId }}
+      defaultValues={{ id: "", waiverNumber: waiverId ?? "" }}
       documentPollerArgs={{
         property: "id",
         documentChecker: (check) => check.recordExists,

diff --git a/react-app/src/features/forms/waiver/capitated/amendment.test.tsx b/react-app/src/features/forms/waiver/capitated/amendment.test.tsx
@@ -111,17 +111,9 @@ describe("AMENDMENT CAPITATED WAIVER WITH EXISTING WAIVERID", () => {
   beforeAll(() => {
     skipCleanup();
     mockApiRefinements();
-
-    const { container: renderedContainer } = renderForm(<AmendmentForm />);
-
-    container = renderedContainer;
   });
   test("waiver id is rendered on page", async () => {
-    const { container: renderedContainer } = renderForm(
-      <AmendmentForm waiverId="AK-0000.R00.11" />,
-    );
-
-    container = renderedContainer;
+    renderForm(<AmendmentForm waiverId="AK-0000.R00.11" />);
 
     const existingWaiverId = screen.getByTestId("existing-waiver-id");
     expect(existingWaiverId).toHaveTextContent("AK-0000.R00.11");

diff --git a/react-app/src/features/forms/waiver/contracting/Amendment.tsx b/react-app/src/features/forms/waiver/contracting/Amendment.tsx
@@ -165,7 +165,6 @@ export const AmendmentForm = ({ waiverId }: AmendmentFormProps) => {
       attachments={{
         faqLink: getFAQLinkForAttachments("contracting-amendment"),
       }}
-      defaultValues={{ id: "", waiverNumber: waiverId }}
       defaultValues={{ id: "", waiverNumber: waiverId ?? "" }}
       documentPollerArgs={{
         property: "id",

diff --git a/react-app/src/features/forms/waiver/contracting/amendment-contracting.test.tsx b/react-app/src/features/forms/waiver/contracting/amendment-contracting.test.tsx
@@ -113,11 +113,7 @@ describe("AMENDMENT CONTRACTING WAIVER", () => {
 
 describe("Contracting Amendment with existing waiver Id", () => {
   test("existing waiver id is filled out", async () => {
-    const { container: renderedContainer } = renderForm(
-      <AmendmentForm waiverId="AK-0000.R00.11" />,
-    );
-
-    container = renderedContainer;
+    renderForm(<AmendmentForm waiverId="AK-0000.R00.11" />);
 
     const existingWaiverId = screen.getByTestId("existing-waiver-id");
     expect(existingWaiverId).toHaveTextContent("AK-0000.R00.11");