fix(email): Fixes an issue with Outlook not correctly displaying the OneMAC logo and header #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th Outlook not rendering the background on <header> when nested within a table
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
tiffanyvu
approved these changes
Jan 6, 2025
andieswift
approved these changes
Jan 6, 2025
tbolt
temporarily deployed
to
fix-email-logo-app
GitHub Actions
Inactive
tbolt
temporarily deployed
to
fix-email-logo-kibana
GitHub Actions
Inactive
tbolt
temporarily deployed
to
fix-email-logo-app
GitHub Actions
Inactive
tbolt
temporarily deployed
to
fix-email-logo-kibana
GitHub Actions
Inactive
13bfrancis
approved these changes
Jan 6, 2025
|
🎉 This PR is included in version 1.5.0-val.101 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
RanyeM
added a commit
that referenced
this pull request
Jan 9, 2025
* feature: adding new FAQ to FAQ page * feature: question should open corresponding section * fix: corrected code back to faq page direct link * fix: removed id * fix: #5 and #6 to expanded section * fix: test coverage * revert package json to what is on main * fix(email): Fixes an issue with Outlook not correctly displaying the OneMAC logo and header (#972) * fixed index test * fix(test): Create mock for calling lambdas (#973) * Added msw endpoints for Lambda, Step Functions, Secure Token Services, and other related services * Added/updated test data to support new endpoints * Updated tests to use the new endpoints instead of mocking individually * fix(email): switch email logo back to using url * fix(schema): remove logic for determining next business day for `submissionDate` (#980) * fix: remove logic for determining next business day for `submissionDate` * fix: update `submissionDate` value * feat(ui): Remove status date from package details pages for all users (#965) * fix(initial verbiage fix): Email verbiage fixes from qa (#974) * correct verbage for med and chip spa * fix issues with verbiage need confirmation * remove comment * add date and attachment logic * update snapshots * Update ChipSpaState.tsx * test(email): proces email test (#979) * feat(test)proces email test * Removed console.log * linter correction * removed a ine * remove brackets * add region * Address change reqeust * feat(test)-submit lambda (#987) * feat(test)-submit lambda * Update withdrawpackage to withdrawrai * linter corrections * Fix some test * Test for malformed objects * Remove import vs code added in * remove console.log * Updatign to use get requestcontext * feat(test) fix email test (#991) * feat(test) fix email test * Update processEmails.test.ts * fix(os) helpers for getting domain and index for opensearch (#992) * created helpers for getting domain and index for opensearch * fixed import * feat(test) updates to s3 calls on backend (#985) * updates to s3 calls on backend * feat(test)-unauthorized submission test (#996) * feat(amend): Add waiver amendment emails (#993) * Feat(playwright performance): Pw perf tests (#959) * feat: initial perf tests for routes fix: refactor * Fix: updated per review comments --------- Co-authored-by: asharonbaltazar <58940073+asharonbaltazar@users.noreply.github.com> --------- Co-authored-by: 13bfrancis <40218571+13bfrancis@users.noreply.github.com> Co-authored-by: Ty Bolt <tybolt@gmail.com> Co-authored-by: Tiffany Forkner <thetif@gmail.com> Co-authored-by: asharonbaltazar <58940073+asharonbaltazar@users.noreply.github.com> Co-authored-by: James Dinh <jdinh8124@gmail.com> Co-authored-by: Thomas Walker <thomas.e.walker88@gmail.com> Co-authored-by: Benjamin Paige <benjamin.paige@gmail.com> Co-authored-by: Jon Schaffer <jschaffer@gswell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Linked Ticket
OY2-31630
💬 Description / Notes
🛠 Changes
<header>. I believe this was causing the background to not render.react-emailuses<table>for layout and having a<header>nested in it is likely causing the issue.📸 Screenshots / Demo
Screenshots provided by @andieswift with Outlook client
Before
After