Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Adding new FAQ to FAQ page #970

Merged
merged 23 commits into from
Jan 9, 2025
Merged

feat(ui): Adding new FAQ to FAQ page #970

merged 23 commits into from
Jan 9, 2025

Conversation

RanyeM
Copy link
Collaborator

@RanyeM RanyeM commented Jan 3, 2025

🎫 Linked Ticket

https://jiraent.cms.gov/browse/OY2-31448?filter=-1

💬 Description / Notes

As a developer, I need to add an FAQ that would allow users in the future to know the history of when we moved the CHIP & Medicaid MMDL templates over to the legacy OneMac system

🛠 Changes

  1. Add question: "Which state plan amendments (SPAs) can I submit in OneMAC?" as the first question on the FAQ page under the State Plan Amendments (SPAs) header (reference figma and screenshot)
  2. Statement should indicate that Medicaid Alternative Benefit Plan and Premium & Cost Sharing SPAs, and CHIP Eligibility SPAs are to be submitted in the OneMAC system as of DATE TBD.
  3. This entry should be the first section on the page.
  4. Upon clicking on the URL's, the application should scroll down to that specific section and open it.
  5. The "Learn more" link in the "New and Notable" box on the welcome page should be updated to link directly to this opened section of the FAQ.
  6. The "Go to FAQs" link in the new "MMDL forms available in OneMAC" notification banner on the home page should also link to this auto-expanded question.

📸 Screenshots / Demo

Screenshot 2025-01-03 at 1 30 56 PM

Screenshot 2024-11-19 140528

@RanyeM RanyeM self-assigned this Jan 3, 2025
@RanyeM RanyeM temporarily deployed to new-faq-question-app January 3, 2025 18:35 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 18:35 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question-kibana January 3, 2025 18:35 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 18:35 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.7% 7145 / 8853
🔵 Statements 79.68% 7459 / 9361
🔵 Functions 71.84% 2077 / 2891
🔵 Branches 48.93% 1350 / 2759
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/components/Banner/MMDLSpaBanner.tsx 66.66% 50% 50% 80% 9, 11
react-app/src/components/Layout/index.test.tsx 100% 70% 97.91% 100%
react-app/src/features/faq/content/oneMACFAQContent.tsx 63.15% 20% 90.9% 63.15% 282-289
react-app/src/features/welcome/index.tsx 78.57% 66.66% 75% 78.57% 19-20, 28
Generated in workflow #1435 for commit d867d18 by the Vitest Coverage Report Action

tbolt
tbolt approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@tbolt tbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Made a small non-blocking suggestion.

react-app/src/features/faq/content/oneMACFAQContent.tsx Outdated Show resolved Hide resolved
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 21:18 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 21:18 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 21:19 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 21:19 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question-app January 3, 2025 21:19 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question-kibana January 3, 2025 21:20 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 21:20 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 21:24 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 21:26 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 21:26 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question-app January 3, 2025 21:26 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question-kibana January 3, 2025 21:26 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 21:26 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 3, 2025 21:30 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question-app January 7, 2025 16:54 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question-kibana January 7, 2025 16:54 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 7, 2025 16:54 — with GitHub Actions Inactive
thetif and others added 13 commits January 9, 2025 14:16
@thetif @RanyeM
fix(test): Create mock for calling lambdas (#973)
2c0c8c2 
* Added msw endpoints for Lambda, Step Functions, Secure Token Services, and other related services
* Added/updated test data to support new endpoints
* Updated tests to use the new endpoints instead of mocking individually
@tbolt @RanyeM
fix(email): switch email logo back to using url
a6cd254
@asharonbaltazar @RanyeM
fix(schema): remove logic for determining next business day for `subm…
7d9f9d5 
…issionDate` (#980)

* fix: remove logic for determining next business day for `submissionDate`

* fix: update `submissionDate` value
@tbolt @RanyeM
feat(ui): Remove status date from package details pages for all users (…
62e1b63 
…#965)
@jdinh8124 @RanyeM
fix(initial verbiage fix): Email verbiage fixes from qa (#974)
70044b8 
* correct verbage for med and chip spa

* fix issues with verbiage need confirmation

* remove comment

* add date and attachment logic

* update snapshots

* Update ChipSpaState.tsx
@thwalker6 @RanyeM
test(email): proces email test (#979)
9fc0ca3 
* feat(test)proces email test

* Removed console.log

* linter correction

* removed a ine

* remove brackets

* add region

* Address change reqeust
@thwalker6 @RanyeM
feat(test)-submit lambda (#987)
8e07ef5 
* feat(test)-submit lambda

* Update withdrawpackage to withdrawrai

* linter corrections

* Fix some test

* Test for malformed objects

* Remove import vs code added in

* remove console.log

* Updatign to use get requestcontext
@thwalker6 @RanyeM
feat(test) fix email test (#991)
162846a 
* feat(test) fix email test
* Update processEmails.test.ts
@thetif @RanyeM
fix(os) helpers for getting domain and index for opensearch (#992)
a7d3e95 
* created helpers for getting domain and index for opensearch
* fixed import
@thetif @RanyeM
feat(test) updates to s3 calls on backend (#985)
da1f80d 
* updates to s3 calls on backend
@thwalker6 @RanyeM
feat(test)-unauthorized submission test (#996)
0b94fa1
@benjaminpaige @RanyeM
feat(amend): Add waiver amendment emails (#993)
73c5fb0
@zerogravit1 @asharonbaltazar @RanyeM
Feat(playwright performance): Pw perf tests (#959)
101a7e9 
* feat: initial perf tests for routes

fix: refactor

* Fix: updated per review comments

---------

Co-authored-by: asharonbaltazar <58940073+asharonbaltazar@users.noreply.github.com>
@RanyeM RanyeM temporarily deployed to new-faq-question January 9, 2025 19:16 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 9, 2025 19:16 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 9, 2025 19:21 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question-kibana January 9, 2025 19:21 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 9, 2025 19:21 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 9, 2025 19:21 — with GitHub Actions Inactive
@RanyeM RanyeM temporarily deployed to new-faq-question January 9, 2025 19:31 — with GitHub Actions Inactive
@RanyeM RanyeM merged commit d4dae28 into main Jan 9, 2025
8 of 9 checks passed
@RanyeM RanyeM deleted the new-faq-question branch January 9, 2025 19:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🎉 This PR is included in version 1.5.0-val.103 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffanyvu tiffanyvu tiffanyvu approved these changes

@tbolt tbolt tbolt approved these changes

Assignees

@RanyeM RanyeM

Labels
released on @val
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@RanyeM @tbolt @tiffanyvu @13bfrancis @thetif @asharonbaltazar @jdinh8124 @thwalker6 @benjaminpaige @zerogravit1