feat(Add comp lib): Add macpro UI component library #13
Conversation
There was a problem hiding this comment.
Theres a few thing id like to see improved here. Also we are still using the existing header with the home and posts link. we should probably include those links in this new header and get rid of the old one right?
also 90% of these commits are just from prettier not automatically formatting on save. Fix that!
src/services/ui/src/pages/Home.tsx
Outdated
| Logo, | ||
| Footer, | ||
| UsaBanner, | ||
| } from "@enterprise-cmcs/macpro-ux-lib"; |
There was a problem hiding this comment.
so id recommend bringing everything in as something like:
import * as UI from "@enterprise-cmcs/macpro-ux-lib"
but also it doesnt seem like you are using most of these things in your file.
it would be nice to use the UsaBanner under the header.
src/services/ui/src/pages/Home.tsx
Outdated
| [ | ||
| { | ||
| href: "", | ||
| text: "Navigational Link", | ||
| }, | ||
| { | ||
| href: "", | ||
| text: "Navigational Link", | ||
| }, | ||
| { | ||
| href: "", | ||
| text: "Navigational Link", | ||
| }, | ||
| { | ||
| href: "", | ||
| text: "Navigational Link", | ||
| }, | ||
| ], | ||
| [ | ||
| { | ||
| href: "", | ||
| text: "Navigational Link", | ||
| }, | ||
| ], |
There was a problem hiding this comment.
im guessing you just copy pastad from the storybook example. but if these links dont go anywhere only include maybe one.
There was a problem hiding this comment.
That's fair. Good point Ben. Yeah if we can really slim this down it would be nice.
|
Code Climate has analyzed commit 2ed5565 and detected 0 issues on this pull request. View more on Code Climate. |
benjaminpaige
changed the title
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
Add ui component for site development
Linked Issues to Close
Closes #https://qmacbis.atlassian.net/browse/OY2-22796
Approach
Added macpro-ux-lib