Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): clicking on side links refreshed page and dismissed banner #621

Merged
merged 7 commits into from
Jul 11, 2024
Merged

fix(ui): clicking on side links refreshed page and dismissed banner #621

merged 7 commits into from
Jul 11, 2024

Conversation

asharonbaltazar
Copy link
Collaborator

Purpose

These changes eliminate the page refresh when clicking on the sidebar links.

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-28520

Approach

The ?id= query param was included in the sidebar link, but it isn't necessary to navigate to anchor links. Remove the query param to address the issue.

@asharonbaltazar asharonbaltazar added type: FIX Submit bug fixes status: READY PR is ready for review labels Jul 2, 2024
@asharonbaltazar
Copy link
Collaborator Author

Screen.Recording.2024-07-02.at.3.10.50.PM.mov

@asharonbaltazar asharonbaltazar temporarily deployed to link-page-refresh-kibana July 2, 2024 19:55 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to link-page-refresh-kibana July 3, 2024 17:27 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to remove-un-required July 3, 2024 17:33 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to remove-un-required July 3, 2024 17:34 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to link-page-refresh-kibana July 5, 2024 18:37 — with GitHub Actions Inactive
@asharonbaltazar asharonbaltazar temporarily deployed to link-page-refresh-kibana July 8, 2024 20:00 — with GitHub Actions Inactive
@mdial89f
Copy link
Contributor

mdial89f commented Jul 9, 2024

looks good, i defer to brian

andieswift
andieswift approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@andieswift andieswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work this looks good! :)

@asharonbaltazar asharonbaltazar merged commit 69c4d86 into master Jul 11, 2024
15 checks passed
@asharonbaltazar asharonbaltazar deleted the link-page-refresh branch July 11, 2024 14:55
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.58 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mdial89f pushed a commit that referenced this pull request Jul 22, 2024
@asharonbaltazar @mdial89f
fix(ui): clicking on side links refreshed page and dismissed banner (#…
d659f05 
…621)

* feat: remove `id` query; remove additional `s` from `ids` array

* fix: correct `s` typo

* fix: correct `s` typo; remove commented out code

* fix: correct Package Details label
mdial89f added a commit that referenced this pull request Jul 23, 2024
@mdial89f
fix(ui): clicking on side links refreshed page and dismissed banner (#…
40fa20a 
…621)

* feat: remove `id` query; remove additional `s` from `ids` array

* fix: correct `s` typo

* fix: correct `s` typo; remove commented out code

* fix: correct Package Details label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andieswift andieswift andieswift approved these changes

@13bfrancis 13bfrancis 13bfrancis approved these changes

@mdial89f mdial89f Awaiting requested review from mdial89f

Assignees
No one assigned
Labels
released on @val status: READY PR is ready for review type: FIX Submit bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asharonbaltazar @mdial89f @13bfrancis @andieswift