Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): update vite #682

Merged
merged 1 commit into from
Jul 25, 2024
Merged

chore(ui): update vite #682

merged 1 commit into from
Jul 25, 2024

Conversation

asharonbaltazar
Copy link
Collaborator

@asharonbaltazar asharonbaltazar commented Jul 25, 2024

Purpose

#644 introduces a new bug – having periods in the URL breaks vite's redirect to index.html, so it always served a 404 if a user navigated directly to /details/1915(b)/OH-1996.R00.00

Approach

Version 5 fixes this bug.

Reference: v5 changelog

Assorted Notes/Considerations/Learning

  • Learning moment for sure: whenever a route is updated, we should test whether or not navigating directly to the URL works

Copy link

codeclimate bot commented Jul 25, 2024

Code Climate has analyzed commit 25503b4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 39.8% (0.0% change).

View more on Code Climate.

@asharonbaltazar asharonbaltazar merged commit 33a0310 into master Jul 25, 2024
21 checks passed
@asharonbaltazar asharonbaltazar deleted the update-vite branch July 25, 2024 18:11
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.66 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @val status: READY PR is ready for review type: FIX Submit bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants