chore(cli pretty): Simplify our runner and have nicer output #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…output cleaner and more colorful, with progress indicators and such
Coverage Report
File CoverageNo changed files found. |
|
Code Climate has analyzed commit 9336da7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.4% (0.0% change). View more on Code Climate. |
asharonbaltazar
approved these changes
Aug 6, 2024
13bfrancis
approved these changes
Aug 6, 2024
|
🎉 This PR is included in version 1.5.0-val.71 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
By reducing the capability of our runner in ways that make sense, we can have colorized output with process indicators.
Linked Issues to Close
None
Approach
This runner file originated from another team and has been pretty bomb proof for years. Recently I grew a little discontent with the output, though, since CDK outputs nice colors and also has progress indicators. These things aren't passed through the existing runner; the progress indicator is just new lines.
Looking at why the runner was made, it seems to be so you can run multiple commands in parallel, but still sort the output based on the prefix. That makes a lot of sense. However, we're not orchestrating any commands in parallel. We do run some things in parallel, but not at the shell level. So, I reduced a lot of its logic, and in so doing we have nicer output.
new:
Assorted Notes/Considerations/Learning
None