Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pr-config): Update playwright config to only use chrome #769

Merged
merged 2 commits into from
Sep 11, 2024
Merged

feat(pr-config): Update playwright config to only use chrome #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bcf363
Update
benjaminpaige Sep 11, 2024
a79fd70
update
benjaminpaige Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ jobs:
role-to-assume: ${{ secrets.AWS_OIDC_ROLE_TO_ASSUME }}
aws-region: us-east-1
role-duration-seconds: 10800
- name: Install Playwright with Chrome
run: npx playwright install --with-deps chromium
- name: Run e2e tests
run: run e2e
- uses: actions/upload-artifact@v3
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"description": "",
"main": "index.js",
"scripts": {
"e2e": "playwright test",
"e2e:ui": "playwright test --ui"
"e2e": "playwright test --project=state-user-chrome",
"e2e:ui": "playwright test --ui --project=state-user-chrome"
},
"dependencies": {
"shared-utils": "*"
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default defineConfig({

{
// we can have different projects for different users/use cases
name: "logged in state user",
name: "state-user-chrome",
use: {
...devices["Desktop Chrome"],
// Use prepared auth state for state submitter.
Expand Down
Loading