Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (g2c): qa changes to match figma #770

Merged
merged 4 commits into from
Sep 11, 2024
Merged

fix (g2c): qa changes to match figma #770

merged 4 commits into from
Sep 11, 2024

Conversation

daniel-belcher
Copy link
Collaborator

Purpose

G2C has some confusion between base and updated figma. Includes change to allow editable lastDivider for fieldArray for future divider standards.

Linked Issues to Close

ticket

@daniel-belcher daniel-belcher self-assigned this Sep 11, 2024
@daniel-belcher daniel-belcher added type: FIX Submit bug fixes status: TESTING PR is being tested by QA labels Sep 11, 2024
Copy link
Contributor

github-actions bot commented Sep 11, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 54.61% 4333 / 7934
🔵 Statements 54.45% 4564 / 8382
🔵 Functions 49.04% 1049 / 2139
🔵 Branches 27.14% 821 / 3025
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
lib/packages/shared-types/forms.ts 100% 100% 100% 100%
react-app/src/components/RHF/FieldArray.tsx 100% 92.85% 100% 100%
react-app/src/components/RHF/RHFTextDisplay.tsx 100% 100% 100% 100%
Generated in workflow #241

Copy link

codeclimate bot commented Sep 11, 2024

Code Climate has analyzed commit 96446f9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.6% (0.0% change).

View more on Code Climate.

Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.80 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @val status: TESTING PR is being tested by QA type: FIX Submit bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants