-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(emails): New Implementation of sending emails w/ cdk and w/o without templates #801
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6191 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6212 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6218 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6267 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 77dcd40 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 38.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.8% (-1.3% change). View more on Code Climate. |
What has been done.
There are a lot of changes in this pr. It should have been done in smaller pieces, but at this point we should focus on, connecting and ensuring that new waiver and chip spa submissions send emails to where they need to go with the content they need to have. The remaining action based functionality we can comment out from the templates for the time being. or remove.
Purpose
In this version of Onemac we do not keep a User Table so we rely on cognito and seatoool for our recipients. This nversion adds functinality to get allState submitters when needed as well as cpoc and srt emails and names and adding them to the correct emails when needed. Also, we are removing the templates for numerous reasons and replacing with the use of React.email library. Which makes it easier to use, cheeper, gives it proper email html content.... etc.
Linked Issues to Close
This should close :
Assorted Notes/Considerations/Learning
This relies on emailAddresses that are secrets but also gets info from seatool (cpoc, srt's) and all state users via ListUsers from cognito. But this does not account for users that sign up but never sign in. Which we are hopefully going to have a solution from IDM asap.
Andie's Notes
The email templates are created with React Email
To test the emails in dev
npm run email-dev
Changes to the components will need to be refreshed to see