Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing app test from workspace setup test #16

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

dwhitestratiform
Copy link
Contributor

Description

This PR removes the app e2e testing functionality of workspace setup. The original intent of this was to run workspace setup, which clones the repos and installs all dependencies. Then it cd's into the app repo spins up the app on the github runner then runs tests. It worked fine for a while but we're getting errors when running and a failing test is not really a failure of the workspace setup job. It makes things more complicated and confusing than its worth. This just removes that and simplifies things

Related ticket(s)


How to test

on merge to main this should kick off a test and we'll see :)

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

@dwhitestratiform
Copy link
Contributor Author

merging without approvals ... itll be ok

@dwhitestratiform dwhitestratiform merged commit dd450f0 into main Aug 29, 2024
1 check passed
@dwhitestratiform dwhitestratiform deleted the update-ws-test branch August 29, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant