Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): mmdlNotifications flag for all notifications & mmdlFaq flag for hiding mmdl cards #1573

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

andieswift
Copy link
Collaborator

@andieswift andieswift commented Jan 9, 2025

Story: https://qmacbis.atlassian.net/browse/OY2-XXXX
Endpoint: https://d2ursihy7l33w4.cloudfront.net/

Details

mmdlNotification - should hide/show only and all notifications
mmdlFaq - should hide/show all changes relating to mmdl

Implementation Notes

  • all notifications will be wrapped in the mmdlNotification LD flag
  • the MMDL cards on new submissions are wrapped in the mmdlFaq flag

Test Plan

  1. Test step 1
  2. Test step 2

Copy link

github-actions bot commented Jan 9, 2025

Endpoint URL - Environment not yet deployed, delete this comment and run the Pull Request workflow again after deploy is complete

@andieswift andieswift changed the title fix(ui): LD flags fix(ui): mmdlNotifications flag for all notifications & mmdlFaq flag for hiding mmdl cards Jan 9, 2025
@andieswift andieswift marked this pull request as ready for review January 9, 2025 18:06
@andieswift andieswift self-assigned this Jan 9, 2025
Copy link
Collaborator

@bflynn-cms bflynn-cms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andieswift andieswift merged commit 69e5bd9 into develop Jan 9, 2025
81 of 103 checks passed
@andieswift andieswift deleted the as-fix-flags branch January 9, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants