Oy2 31159 - simplify notification logic (#1581) #1582
Merged
+5
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dont auto dismiss user notifications * remove dismissed notifications only when manually dismissed * fix bug in dismiss notifications from UI * simplify notification storage
Dark-Knight-1313
requested review from
kristin-at-theta and
bflynn-cms
as code owners
bflynn-cms
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dont auto dismiss user notifications
remove dismissed notifications only when manually dismissed
fix bug in dismiss notifications from UI
simplify notification storage
Story: https://qmacbis.atlassian.net/browse/OY2-XXXX
Endpoint: See github-actions bot comment
Details
A quick summary of the intended outcome of this PR.
Changes
Implementation Notes
Test Plan