Change handleDeleteFile in app-web #2822
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haworku
reviewed
Oct 8, 2024
services/app-web/src/s3/s3Amplify.ts
Outdated
| { key: fullKey }, | ||
| { metadata: updatedMetadata } | ||
| ) | ||
| console.info('Successfully updated file metadata') |
There was a problem hiding this comment.
Interesting idea, I like it because we still retain something to show that a field may have been removed in the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We ran into an issue where a state submitted, but the contract document that was uploaded was missing from the package. We decided we don't really have a need for doing an actual delete from
app-web, so this changes thehandleDeleteFilefunc to not actually delete files, but tag the metadata instead when a delete operation occurs.Related issues
https://jiraent.cms.gov/browse/MCR-4491