Upgrade storybook deps #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2021
|
Running into storybookjs/storybook#16837. We do need to upgrade react router to 6.0 (#638 ). Don't want to mix together that change in this PR though since its significant code change. See 67d6579 for temporary workaround |
- address storybookjs/storybook#16837 - this is temporary solution until we upgrade app to v6 of react-router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's a good idea™ to upgrade storybook dependencies all together rather than incrementally. There is a command
npx sb upgradeto do this. Since dependabot is letting us know we have some deps ready for upgrade, let's do that now.