Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAR-24: AWS snapshot recovery #821

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

mikewallace1979
Copy link
Contributor

No description provided.

Fixes two errors in the documentation for `barman recover` by:

1. Updating the `--gcp-zone` to reflect that it is an option which
   overrides the configured `gcp_zone` rather than a required
   parameter.
2. Adding the `--azure-resource-group` option which was omitted when
   the option was added to the code.
@mikewallace1979 mikewallace1979 marked this pull request as ready for review July 10, 2023 13:13
Copy link
Contributor

@gcalacoci gcalacoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Adds the additional functionality required for barman and
barman-cloud-restore to be able to recover AWS snapshot backups.

This is achieved by:

- Adding the `--aws-region` argument to `barman recover` and
  `barman-cloud-restore`. This is used to find the recovery instance
  and attached disks during the verification phase of the recovery.

- Passing the source snapshot name from the volume metadata to the
  AwsVolumeMetadata constructor so that it can be used by the recovery
  executor to verify that a disk cloned from that snapshot is
  attached to the recovery instance and correctly mounted.

Closes BAR-24.
@edb-sonar-app
Copy link

edb-sonar-app bot commented Jul 11, 2023

@mikewallace1979 mikewallace1979 merged commit aeecbc8 into master Jul 11, 2023
9 checks passed
@mikewallace1979 mikewallace1979 deleted the bar-24-aws-snapshot-recovery branch July 11, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants