Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests getting installed as a separate top level pacakge #21

Closed
PythonCHB opened this issue Jan 12, 2019 · 3 comments · May be fixed by conda-forge/hrds-feedstock#2
Closed

tests getting installed as a separate top level pacakge #21

PythonCHB opened this issue Jan 12, 2019 · 3 comments · May be fixed by conda-forge/hrds-feedstock#2
Assignees

Comments

@PythonCHB
Copy link
Contributor

The tests are put in a package that is next to the hrds package, and the setup.py uses setuptools.find_packages to to identify the packages to install. So when run, you get a top-level package called "tests" with the hrds tests in it. This is not good.

Here are some thoughts on where to put tests:

http://pythonchb.github.io/PythonTopics/where_to_put_tests.html

I've provided a PR here that puts the tests internal to the package:

#18

I also added formatting, etc changes to the setup.py in that PR.

@PythonCHB
Copy link
Contributor Author

NOTE: this could also be addressed by removing teh init.py, if you want to keep the tests separate from the package -- but with a tet suite this small, I think installing is is good.

@PythonCHB
Copy link
Contributor Author

This is now fixed in #24

@jhill1
Copy link
Contributor

jhill1 commented Apr 9, 2019

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants