You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The tests are put in a package that is next to the hrds package, and the setup.py uses setuptools.find_packages to to identify the packages to install. So when run, you get a top-level package called "tests" with the hrds tests in it. This is not good.
NOTE: this could also be addressed by removing teh init.py, if you want to keep the tests separate from the package -- but with a tet suite this small, I think installing is is good.
The tests are put in a package that is next to the hrds package, and the setup.py uses setuptools.find_packages to to identify the packages to install. So when run, you get a top-level package called "tests" with the hrds tests in it. This is not good.
Here are some thoughts on where to put tests:
http://pythonchb.github.io/PythonTopics/where_to_put_tests.html
I've provided a PR here that puts the tests internal to the package:
#18
I also added formatting, etc changes to the setup.py in that PR.
The text was updated successfully, but these errors were encountered: