[Plugin][Bug]: Plugin isn't activated properly

[ooker777]

Issue validation

• I checked the issue to prevent duplicate
• I checked my configurations files and the documentation

Plugin version

6.0.1

Describe the bug

The plugin isn't actually activated even though the button is on: there is no setting button, no command in the palette. Manually copying the content rather the file is no used either.

How to reproduce ?

Guaranteed methods:

• Manually copy the plugin folder from another vault
• Install the plugin as usual, then copy the data.json (either as the file or the content)

Sometimes work:

• Install the plugin as usual, then make a dummy edit on the setting, then reload the vault

I tried to disable all other plugins but it doesn't help. However this only seems to happen on my real vaults. Testing on the test vault it doesn't happen.

Minimal Reproducible Example

Manually copy the plugin folder from another vault

Configuration

It's not possible to open the setting panel, there is no way to export it. However here is the content of the data.json:

{
  "github": {
    "user": "QuaCau-TheSphere",
    "repo": "quan-ly-du-an-va-cong-cu-nghi-web",
    "branch": "main",
    "automaticallyMergePR": true,
    "api": {
      "tiersForApi": "Github Free/Pro/Team (default)",
      "hostname": ""
    },
    "workflow": {
      "name": "",
      "commitMessage": "[PUBLISHER] Merge"
    }
  },
  "upload": {
    "behavior": "obsidian",
    "defaultName": "docs",
    "rootFolder": "",
    "yamlFolderKey": "",
    "frontmatterTitle": {
      "enable": true,
      "key": "filename"
    },
    "replaceTitle": [],
    "replacePath": [],
    "autoclean": {
      "enable": true,
      "excluded": [
        "asset"
      ]
    },
    "folderNote": {
      "enable": false,
      "rename": "index.md"
    },
    "metadataExtractorPath": ""
  },
  "conversion": {
    "hardbreak": true,
    "dataview": true,
    "censorText": [],
    "tags": {
      "inline": true,
      "exclude": [],
      "fields": []
    },
    "links": {
      "internal": true,
      "unshared": false,
      "wiki": false,
      "slugify": false
    }
  },
  "embed": {
    "attachments": true,
    "keySendFile": [],
    "notes": false,
    "folder": "docs/attachments"
  },
  "plugin": {
    "shareKey": "share",
    "fileMenu": true,
    "editorMenu": true,
    "excludedFolder": [
      "Thiết lập"
    ],
    "copyLink": {
      "enable": false,
      "links": "",
      "removePart": [],
      "addCmd": false
    },
    "noticeError": false,
    "displayModalRepoEditing": false
  }
}

Obsidian information

SYSTEM INFO:
	Obsidian version: v1.3.5
	Installer version: v1.3.3
	Operating system: Windows 10 Home Single Language 10.0.22621
	Login status: logged in
	Catalyst license: none
	Insider build toggle: off
	Live preview: on
	Legacy editor: off
	Base theme: light
	Community theme: none
	Snippets enabled: 0
	Restricted mode: off
	Plugins installed: 41
	Plugins enabled: 23
		1: Divide & Conquer v1.0.0
		2: Hot Reload v0.1.8
		3: Github Publisher v6.0.1
		4: Chat View v1.6.0
		5: DB Folder v3.4.0
		6: Metadata Menu v0.4.21
		7: Mind Map v1.1.0
		8: Multi-Column Markdown v0.8.0
		9: Natural Language Dates v0.6.1
		10: Note Refactor v1.7.1
		11: Notion-Like Tables v6.16.0
		12: Obsidian Git v2.20.3
		13: Obsidian Leaflet v5.6.1
		14: Party🎉 v2.1.0
		15: Plugin Groups v2.1.0
		16: Quick Explorer v0.2.8
		17: Regex Find/Replace v1.2.0
		18: Style Settings v1.0.6
		19: Super Simple Time Tracker v0.1.7
		20: Tasks v3.10.0
		21: Templater v1.16.0
		22: Various Complements v8.3.1
		23: Version History Diff v2.1.0

RECOMMENDATIONS:
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

[Mara-Li]

FIRST : never share your github token.

Second : you seems to use an old version of the settings.

Here mine:

{
  "github": {
    "branch": "main",
    "automaticallyMergePR": true,
    "api": {
      "tiersForApi": "Github Free/Pro/Team (default)",
      "hostname": ""
    },
    "otherRepo": [
      {
        "smartKey": "test",
        "branch": "main",
        "automaticallyMergePR": true,
        "api": {
          "tiersForApi": "Github Free/Pro/Team (default)",
          "hostname": ""
        },
        "createShortcuts": false,
        "shareKey": "share",
        "copyLink": {
          "links": "https://www.mara-li.fr/",
          "removePart": []
        },
        "workflow": {
          "name": "",
          "commitMessage": "[skip netlify] PUBLISHER"
        }
      }
    ],
    "workflow": {
      "name": "",
      "commitMessage": "[skip netlify] PUBLISHER"
    }
  },
  "upload": {
    "behavior": "yaml",
    "subFolder": "",
    "defaultName": "docs/hidden",
    "rootFolder": "docs",
    "yamlFolderKey": "category",
    "frontmatterTitle": {
      "enable": true,
      "key": "name"
    },
    "replaceTitle": [],
    "autoclean": {
      "enable": true,
      "excluded": [
        "docs/assets/js",
        "docs/assets/meta",
        "docs/assets/css",
        "tags.md",
        "graph.md"
      ]
    },
    "folderNote": {
      "enable": true,
      "rename": "index.md"
    },
    "metadataExtractorPath": "",
    "replacePath": []
  },
  "conversion": {
    "hardbreak": false,
    "dataview": false,
    "censorText": [
      {
        "entry": "10. PROJECT/ETERNITY/Wiki/Personnages",
        "replace": "",
        "after": true
      }
    ],
    "tags": {
      "inline": true,
      "exclude": [],
      "fields": []
    },
    "links": {
      "internal": true,
      "unshared": false,
      "wiki": false
    }
  },
  "embed": {
    "attachments": true,
    "keySendFile": [
      "image"
    ],
    "notes": true,
    "folder": "docs/assets/img"
  }
}

It seems that the key otherRepo is created. But to do more, I need the logs.

Could you please provide the log when you try to enable the plugin, for example?

[ooker777]

hmm, but then when update the plugin, the old setting isn't updated as well?

[Mara-Li]

Yeap, normally it must be...
Could you please send me the log when you load the plugin?

[ooker777]

Github Publisher unloaded
plugin:obsidian-mkdocs-publisher:56 Github Publisher v.6.0.1 (lang: en) loaded
plugin:obsidian-mkdocs-publisher:51 Uncaught (in promise) TypeError: e.settings.github.otherRepo is not iterable
    at eval (plugin:obsidian-mkdocs-publisher:51:9847)
    at Generator.next (<anonymous>)
    at eval (plugin:obsidian-mkdocs-publisher:2:871)
    at new Promise (<anonymous>)
    at D (plugin:obsidian-mkdocs-publisher:2:691)
    at dn (plugin:obsidian-mkdocs-publisher:51:7039)
    at ps.eval (plugin:obsidian-mkdocs-publisher:56:51887)
    at Generator.next (<anonymous>)
    at s (plugin:obsidian-mkdocs-publisher:2:729)
e

[Mara-Li]

Seems that the key is not created with the update. Thanks you! Will try to fix that when I have the time^^