Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate frontmatter (with new Obsidian API) #317

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fix: duplicate frontmatter (with new Obsidian API) #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"i18next": "^23.9.0",
"jest": "^29.7.0",
"js-base64": "^3.7.6",
"obsidian": "^1.4.11",
"obsidian": "1.5.7-1",
"obsidian-dataview": "^0.5.64",
"obsidian-plugin-cli": "^0.9.0",
"obsidian-undocumented": "^0.1.3",
Expand Down
24 changes: 12 additions & 12 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/GitHub/upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
} from "obsidian";

import { convertToHTMLSVG } from "../conversion/compiler/excalidraw";
import { mainConverting } from "../conversion/convert_text";
import { mainConverting } from "../conversion";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the comprehensive changes across multiple files, it's crucial to ensure that the updated import paths and refactored code do not introduce any regressions or break existing functionality. Consider adding or updating unit tests to cover the changes made in this PR, especially for critical functions like publish, uploadImage, and uploadText. This will help maintain the reliability of the system as it evolves.

Would you like assistance in creating or updating the unit tests to cover these changes?

import {
getImagePath,
getReceiptFolder,
Expand Down
2 changes: 1 addition & 1 deletion src/conversion/compiler/embeds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
LinkedNotes,
MultiProperties} from "../../settings/interface";
import {isShared} from "../../utils/data_validation_test";
import { addToYaml } from "../convert_text";
import { addToYaml } from "..";
import { createRelativePath, getTitleField, regexOnFileName } from "../file_path";


Expand Down
Loading
Loading