Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nanobot #251

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Add nanobot #251

wants to merge 38 commits into from

Conversation

anitacaron
Copy link
Collaborator

No description provided.

cmungall
cmungall approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at first I was massively confused... I was going to suggest that "nanobot" belongs in OBI or ENVO and the "exposure to nanobot" term is here...

matentzn
matentzn reviewed Jan 24, 2024
View reviewed changes
src/ontology/ecto.Makefile Outdated Show resolved Hide resolved
src/ontology/_nanobot Outdated Show resolved Hide resolved
@anitacaron
Copy link
Collaborator Author

Should all tables from patterns be added? I added the first three for testing.

@matentzn
Copy link
Contributor

Your call - ultimately we need them all, but for we can iterate!

@anitacaron
Copy link
Collaborator Author

I'll add all tables.

anitacaron and others added 19 commits January 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

@cmungall cmungall cmungall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anitacaron @matentzn @cmungall