Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added frost heaving process #704

Merged
merged 6 commits into from
Mar 4, 2019
Merged

added frost heaving process #704

merged 6 commits into from
Mar 4, 2019

Conversation

stevenchong
Copy link
Contributor

No description provided.

@stevenchong stevenchong requested a review from pbuttigieg March 4, 2019 20:53
@stevenchong
Copy link
Contributor Author

added frost heaving process for issue #703

@stevenchong stevenchong changed the title added frost heaving added frost heaving process Mar 4, 2019
@pbuttigieg
Copy link
Member

Hi @stevenchong

Two points of revision:

Outputs

image

These axioms suggest that the FHP always has a palsa and a frost-formed hummock as outputs, which isn't the case.

It's better to add the output of relation on the palsa and hummock classes. Here's what it looks like for palsa:

image

Some more axioms

I added a few more axioms on the process to weave it into the ENVO background model a little more deeply:

image

Note that processes can have process parts (but not continuant parts, those are listed as participants)

Changed axioms from 'has output' to 'formed as result of' for palsa and frost-formed hummock
@stevenchong
Copy link
Contributor Author

I edited the relations for 'frost-formed hummock' and 'palsa' from output of to formed as result of as they seem more appropriate.

FYI, I also added in the envoPolar in_subset AP to adfreezing, cryopeg, and frost heaving process. I'll add in the envoNceas to the in_subset APs in a follow up commit.

@pbuttigieg
Copy link
Member

@stevenchong good stuff

I edited the relations for 'frost-formed hummock' and 'palsa' from output of to formed as result of as they seem more appropriate.

Yes, that's better

FYI, I also added in the envoPolar in_subset AP to adfreezing, cryopeg, and frost heaving process. I'll add in the envoNceas to the in_subset APs in a follow up commit

Great.

stevenchong and others added 2 commits March 4, 2019 14:47
Added envoNceas in_subset APs to adfreezing, cryopeg, and frost heaving process.
@pbuttigieg
Copy link
Member

Looking good, one last thing based on @cmungall's comment on issue #703 (comment)

We should create frost heave to go with frost heaving and gather up things like palsa's and frost-formed hummocks.

I'll do that with an equivalence axiom in a few ...

@pbuttigieg
Copy link
Member

PS: @stevenchong be careful with the in subset property - each subset should have it's own AP.

This won't be understood by the Makefile:
image

But this will be:
image

I'll revise that in my next commit...

@pbuttigieg
Copy link
Member

Following up on #704 (comment)

I've added an defined class for frost heave (the ME) defined by the process. Sorts out the palsa and frost-formed hummock quite nicely.

@pbuttigieg
Copy link
Member

Cool, I think we're ready for merge! Party time...

@pbuttigieg pbuttigieg merged commit 3ffa969 into master Mar 4, 2019
@pbuttigieg
Copy link
Member

We're keeping this branch alive as this PR is used in our documentation for training purposes.

Copy link
Member

@pbuttigieg pbuttigieg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to conversation thread, where contents were reviewed.

@pbuttigieg pbuttigieg deleted the ntr-frost-heaving branch June 2, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants