-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added frost heaving process #704
Conversation
added frost heaving process for issue #703 |
Hi @stevenchong Two points of revision: OutputsThese axioms suggest that the FHP always has a palsa and a frost-formed hummock as outputs, which isn't the case. It's better to add the Some more axiomsI added a few more axioms on the process to weave it into the ENVO background model a little more deeply: Note that processes can have process parts (but not continuant parts, those are listed as participants) |
I edited the relations for 'frost-formed hummock' and 'palsa' from FYI, I also added in the envoPolar in_subset AP to adfreezing, cryopeg, and frost heaving process. I'll add in the envoNceas to the in_subset APs in a follow up commit. |
@stevenchong good stuff
Yes, that's better
Great. |
Added envoNceas in_subset APs to adfreezing, cryopeg, and frost heaving process.
Looking good, one last thing based on @cmungall's comment on issue #703 (comment) We should create I'll do that with an equivalence axiom in a few ... |
PS: @stevenchong be careful with the This won't be understood by the Makefile: I'll revise that in my next commit... |
Following up on #704 (comment) I've added an defined class for |
Cool, I think we're ready for merge! Party time... |
We're keeping this branch alive as this PR is used in our documentation for training purposes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to conversation thread, where contents were reviewed.
No description provided.