Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update llama #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update llama #104

wants to merge 1 commit into from

Conversation

ftynse
Copy link
Collaborator

@ftynse ftynse commented Jul 18, 2024

  • fix rmsnorm to compute what it should
  • use complex numbers instead of rotation matrix
  • don't append

@ftynse
update llama
ad7b5d2 
- fix rmsnorm to compute what it should
- use complex numbers instead of rotation matrix
- don't append
@ftynse ftynse requested a review from wsmoses July 18, 2024 09:30
@ftynse
Copy link
Collaborator Author

ftynse commented Jul 18, 2024

Adapting this from another version that is known to run on proper data. Note that the weights for dense layers coming from pytorch are transposed and my version is using x @ weights.mT whereas this version uses weights @ x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ftynse @wsmoses