If Index cast optimization #544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Mar 29, 2025
| Value value = result.value(); | ||
|
|
||
| // Skip if the result is not an integer type that can be index-cast | ||
| if (!value.getType().isIntOrIndex()) { |
Member
There was a problem hiding this comment.
can we add a further restriction here if the yielded results are both constants?
Member
There was a problem hiding this comment.
or I suppose if at least one of the yielded results are constants*
Member
There was a problem hiding this comment.
[that way it is in some sense work reducing]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affine.if result if yields a constant with one user that does index cast on it. Then the index cast is moved inside the affine.if