Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test YaoBlocks #431

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Test YaoBlocks #431

wants to merge 4 commits into from

Conversation

mofeing
Copy link
Collaborator

@mofeing mofeing commented Dec 28, 2024

Needed to check that #426 doesn't break integration with YaoBlocks

@avik-pal
Copy link
Collaborator

@mofeing
Copy link
Collaborator Author

mofeing commented Dec 29, 2024

LLVM ERROR: Program used external function 'sincos' which could not be resolved!

ah dammit, we are aware of this error. apparently macos x64 libc doesn't export math symbols. it's the reason why we don't test some numeric ops on macos x64.

should be fixed now by skipping the test on that platform

@wsmoses
Copy link
Member

wsmoses commented Dec 29, 2024

eventually we can fix that by manually exporting a sincos ourselves

@mofeing
Copy link
Collaborator Author

mofeing commented Dec 29, 2024

eventually we can fix that by manually exporting a sincos ourselves

we could do it by adding a file to the build conditionally, but the question again is if we really want to support macOS x64

@wsmoses
Copy link
Member

wsmoses commented Dec 29, 2024

eventually we can fix that by manually exporting a sincos ourselves

we could do it by adding a file to the build conditionally, but the question again is if we really want to support macOS x64

At minimum because selfishly my personal laptop is an Intel Mac it would be nice. But also I can fix that problem in another way too xD

@mofeing
Copy link
Collaborator Author

mofeing commented Dec 29, 2024

At minimum because selfishly my personal laptop is an Intel Mac it would be nice. But also I can fix that problem in another way too xD

ahh ups jajajaj

okay then, how could we export those symbols? i don't understand why those symbols are missing in the first place.
do we need to reimplement them manually or it's just that the symbol filtering on mac is filtering too much?

if it's the symbol filter, then #421 should fix it because it refactors the filter to just stop exporting symbols that match the glob pattern *llvm*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants