[IFRT] add ifrt-proxy server and client bindings #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofeing
commented
Feb 15, 2025
deps/ReactantExtra/API.cpp
Outdated
Comment on lines
1433
to
1449
| std::string tpu_library_path; | ||
| if (auto path = llvm::sys::Process::GetEnv(kEnvTpuLibraryPath)) { | ||
| tpu_library_path = *path; | ||
| } else if (tpu_path) { | ||
| tpu_library_path = std::string(tpu_path); | ||
| } else { | ||
| *error = "Could not find TPU path"; | ||
| return nullptr; | ||
| } | ||
|
|
||
| const PJRT_Api *pluginLoad = | ||
| LoadPjrtPlugin("tpu", tpu_library_path.c_str(), error); | ||
| if (pluginLoad == nullptr) | ||
| return nullptr; | ||
| auto tpu_status = InitializePjrtPlugin("tpu", error); | ||
| if (tpu_status) | ||
| return nullptr; |
There was a problem hiding this comment.
we need to test wether to load the TPU plugin here (on this function call), on call by the factory (inside the closure then) or even before
wsmoses
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.