[IFRT] add c-bindings for "Held" PjRt classes #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofeing
commented
Feb 15, 2025
deps/ReactantExtra/API.cpp
Outdated
Comment on lines
1566
to
1574
| auto options = std::make_unique<CompileOptions>( | ||
| GenerateCompileOptions( | ||
| device_id, | ||
| is_sharded, | ||
| mesh_ids, | ||
| num_mesh_ids, | ||
| xla_gpu_cuda_data_dir | ||
| ) | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
this is crashing because compiler->Compile is expecting a ifrt::Compiler::CompileOptions and not xla::CompileOptions
@avik-pal would you mind taking care of this? i think we need to use this https://github.com/openxla/xla/blob/81335eabdc55f0a2ff02bde7f79da7adda7af2c9/xla/python/ifrt/ir/ifrt_ir_program.h#L102-L109
wsmoses
approved these changes
Feb 15, 2025
Collaborator
Author
|
Do not merge. See #751 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wsmoses this PR should solve the issues that arised in #738
@avik-pal i've added
ifrt_client_make_single_shard_array_from_host_bufferfor creating single-shard arrays andifrt_client_assemble_array_from_single_shardsfor joining them into a sharded array.ifrt_pjrt_ArrayFromHostBuffer(now renamed toifrt_pjrt_array_create) is "IFRT-PjRt" only and wouldn't work for IFRT-proxy.the only missing thing to use
ifrt_client_make_single_shard_array_from_host_bufferis that we need to pass aifrt::Device*...