Skip to content

feat: JLL changes for sdy.sharding_constraint #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2025
Merged

feat: JLL changes for sdy.sharding_constraint #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions deps/ReactantExtra/API.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,10 +2133,13 @@ hloShardingFromTensorShardingAttr(mlir::sdy::TensorShardingAttr attr,
xla::sdy::convertToHloSharding(attr, get_mesh_attr, manual_axes));
}

extern "C" mlir::sdy::TensorShardingAttr
hloShardingToTensorShardingAttr(const xla::HloSharding *hloSharding,
mlir::sdy::MeshAttr meshAttr, int64_t rank,
const bool *isClosed, const int64_t *priority) {
// XXX: This is incorrect for multiple meshes. We need to use the current mesh
// to generate this instead of the global mesh Currently we are storing only a
// single mesh, so we can just use this.
extern "C" mlir::sdy::TensorShardingAttr hloShardingToTensorShardingAttr(
mlir::MLIRContext *context, const xla::HloSharding *hloSharding,
mlir::StringAttr meshName, mlir::sdy::MeshAttr meshAttr, int64_t rank,
const bool *isClosed, const int64_t *priority) {
const SmallDenseMap<int64_t, StringRef> deviceIdToMaximalMeshName =
SmallDenseMap<int64_t, StringRef>();
mlir::sdy::TensorShardingAttr tensorShardingAttr =
Expand All @@ -2157,7 +2160,9 @@ hloShardingToTensorShardingAttr(const xla::HloSharding *hloSharding,
isClosed[i], dimPriority));
}

return tensorShardingAttr;
return mlir::sdy::TensorShardingAttr::get(
context, meshName, tensorShardingAttr.getDimShardings(),
tensorShardingAttr.getReplicatedAxes());
}

#pragma endregion
Expand Down
Loading