Skip to content

fix: number tracing #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avik-pal merged 1 commit into from
Mar 6, 2025
Merged

fix: number tracing #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tracing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Base.@nospecializeinfer function traced_type_inner(
@nospecialize(track_numbers::Type),
@nospecialize(sharding)
)
if Mode == ArrayToConcrete && T <: track_numbers
if mode == ArrayToConcrete && T <: track_numbers
return ConcretePJRTNumber{
T,Sharding.ndevices(sharding),Sharding.shard_type(typeof(sharding), 0)
}
Expand Down
24 changes: 24 additions & 0 deletions test/tracing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,17 @@ struct Wrapper{A,B}
b::B
end

struct Descent{T}
eta::T
end

struct RMSProp{Teta,Trho,Teps,C<:Bool}
eta::Teta
rho::Trho
epsilon::Teps
centred::C
end

@testset "Tracing" begin
@testset "trace_type" begin
@testset "mode = ConcreteToTraced" begin
Expand Down Expand Up @@ -242,4 +253,17 @@ end
st_traced = Reactant.to_rarray(st; track_numbers=Number)
@test st_traced.training isa Val{true}
end

@testset "to_rarray(::AbstractRule)" begin
opt = Descent(0.1)
opt_traced = Reactant.to_rarray(opt; track_numbers=AbstractFloat)
@test opt_traced.eta isa ConcreteRNumber{Float64}

opt = RMSProp(0.1, 0.9, 1e-8, true)
opt_traced = Reactant.to_rarray(opt; track_numbers=AbstractFloat)
@test opt_traced.eta isa ConcreteRNumber{Float64}
@test opt_traced.rho isa ConcreteRNumber{Float64}
@test opt_traced.epsilon isa ConcreteRNumber{Float64}
@test opt_traced.centred isa Bool
end
end
Loading