Skip to content

Update Reactant version and commit hash #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update Reactant version and commit hash #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6eb28b
Update Reactant version and commit hash
wsmoses Nov 9, 2025
284e7d2
Update GPU version handling in platform_augmentation.jl
wsmoses Nov 9, 2025
9f59e28
Update Reactant commit hash in build_tarballs.jl
wsmoses Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions R/Reactant/build_tarballs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ include(joinpath(YGGDRASIL_DIR, "fancy_toys.jl"))

name = "Reactant"
repo = "https://github.com/EnzymeAD/Reactant.jl.git"
reactant_commit = "e2f5c8c8c77f0f936d856486e4dd207161f81bf7"
version = v"0.0.257"
reactant_commit = "6e5667c3fa41ad59add95c6b8bc22c2201bbe7f5"
version = v"0.0.259"

sources = [
GitSource(repo, reactant_commit),
Expand Down Expand Up @@ -463,6 +463,9 @@ if [[ "${bb_full_target}" == *gpu+rocm* ]]; then
find bazel-bin
find ${libdir}

install -Dvm 755 \
$ROCM_PATH/lib/rocm_sysdeps/lib/librocm_sysdeps_dw.so* \
-t ${libdir}/rocm_sysdeps/lib

install -Dvm 755 \
$ROCM_PATH/lib/rocm_sysdeps/lib/librocm_sysdeps_numa.so* \
Expand Down
12 changes: 6 additions & 6 deletions R/Reactant/platform_augmentation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ else
nothing
end

const cuda_version_preference = if haskey(preferences, "gpu_version")
const gpu_version_preference = if haskey(preferences, "gpu_version")
expected = ("none", "12.9", "13.0", "7.1")
if isa(preferences["gpu_version"], String) && preferences["gpu_version"] in expected
preferences["gpu_version"]
Expand Down Expand Up @@ -118,11 +118,11 @@ function augment_platform!(platform::Platform)
path = Libdl.dlpath(handle)
Libdl.dlclose(handle)

if cuda_version_tag == "none" && current_cuda_version isa VersionNumber
if gpu_version_tag == "none" && current_cuda_version isa VersionNumber
if v"12" <= current_cuda_version < v"13"
cuda_version_tag = "12.9"
gpu_version_tag = "12.9"
elseif v"13.0" <= current_cuda_version < v"14"
cuda_version_tag = "13.0"
gpu_version_tag = "13.0"
else
@warn "CUDA version $(current_cuda_version) in $(path) not supported with this version of Reactant (min supported: 12)"
end
Expand All @@ -144,8 +144,8 @@ function augment_platform!(platform::Platform)
#Libdl.dlclose(handle)
gpu_version_tag = "7.1"

@debug "Adding include dependency on $(path)"
Base.include_dependency(path)
#@debug "Adding include dependency on $(path)"
#Base.include_dependency(path)
gpu = "rocm"
end

Expand Down
Loading