Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor freq keywords #159

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
330a7ad
refactor frequency selection and averaging handling
bhazelton Mar 30, 2023
79d861a
fix plotfile naming
bhazelton Apr 3, 2023
efe6f43
don't error if n_kz ne n_freq if we've done flagging or averaging
bhazelton Apr 3, 2023
63f4aa6
Fix difference plots to allow differencing with and without flags
bhazelton Apr 4, 2023
c95c0b9
calculate z_mpc_length based on nominal freqs if irregular freq spacing
bhazelton Apr 4, 2023
2c78df2
move structure setup logic from ps_diff_wrapper to new file for reuse
bhazelton Apr 5, 2023
eff34ce
update ratio & comp1d wrappers
bhazelton Apr 5, 2023
632492d
fix derived input cubes to point at full freq files
bhazelton Apr 17, 2023
669ef24
add metadata only option to ps_freq_select_avg
bhazelton Apr 17, 2023
3d2903d
fix beam_full_savefile detection
bhazelton Apr 18, 2023
70117d5
fix beam handling when only averaging
bhazelton Apr 18, 2023
5ae4691
use n_freq not n_kz now where appropriate now that they can be different
bhazelton Apr 19, 2023
8ef27b7
fix iteration over savefile_k0_use
PyxieLouStar Apr 20, 2023
5552f62
fix vis_sigma calc when averaging in freq
bhazelton May 19, 2023
01ce62c
fix bug in vis_sigma freq averaging.
bhazelton May 19, 2023
a691b42
use freq_flag_name if freq_flags are not set; change frequency differ…
PyxieLouStar May 23, 2023
a2f7b0c
fix rebase mistakes
PyxieLouStar Oct 3, 2023
9523095
Add frequency binning option
PyxieLouStar Jan 9, 2024
6d46d5f
update diff and ratio wrappers
PyxieLouStar Jan 9, 2024
174a73d
Add frequency keywords to dictionary
PyxieLouStar Jan 10, 2024
82d0143
add option for custom kz array
PyxieLouStar Jan 24, 2024
d77b3a8
update single_cube_dft
PyxieLouStar Mar 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix vis_sigma calc when averaging in freq
  • Loading branch information
bhazelton authored and PyxieLouStar committed Sep 14, 2023

Verified

This commit was signed with the committer’s verified signature.
upchuk Daniel Sipos
commit 5552f6214f0e9cd2dc806368e054e9a65aa997f3
8 changes: 6 additions & 2 deletions ps_core/ps_kcube.pro
Original file line number Diff line number Diff line change
@@ -37,6 +37,7 @@ pro ps_kcube, file_struct, sim = sim, fix_sim_input = fix_sim_input, $
ps_freq_select_avg, file_struct, n_vis_freq, refresh_options = refresh_options, $
freq_options = freq_options, ps_options = ps_options
frequencies = freq_options.frequencies
full_n_vis_freq = n_vis_freq
n_vis_freq = freq_options.n_vis_freq
endif else begin
frequencies = file_struct.frequencies
@@ -158,7 +159,9 @@ pro ps_kcube, file_struct, sim = sim, fix_sim_input = fix_sim_input, $

if freq_options.freq_avg_factor gt 1 then begin
new_vis_sigma_adam = reform(vis_sigma_adam, freq_options.freq_avg_factor, n_elements(frequencies))
new_vis_sigma_adam = mean(new_vis_sigma_adam, dimension=1)
full_n_vis_freq_temp = reform(full_n_vis_freq, freq_options.freq_avg_factor, n_elements(frequencies))
new_vis_sigma_adam = sqrt( $
total(new_vis_sigma_adam^2 * full_n_vis_freq_temp, 1) / total(full_n_vis_freq_temp, 1))
vis_sigma_adam = new_vis_sigma_adam
endif

@@ -176,7 +179,8 @@ pro ps_kcube, file_struct, sim = sim, fix_sim_input = fix_sim_input, $
endif
if freq_options.freq_avg_factor gt 1 then begin
new_vis_sigma_ian = reform(vis_sigma_ian, freq_options.freq_avg_factor, n_elements(frequencies))
new_vis_sigma_ian = mean(new_vis_sigma_ian, dimension=1)
new_vis_sigma_ian = sqrt( $
total(new_vis_sigma_ian^2 * full_n_vis_freq_temp, 1) / total(full_n_vis_freq_temp, 1))
vis_sigma_ian = new_vis_sigma_ian
endif
vis_sigma = vis_sigma_ian