[NF] Ring Magnet in FEMM #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
This PR introduces SlotM18 for "Ring Magnet". The purpose of this new slot is to handle the following topology:
Previously we were using SlotM11 (Polar) but with a slot pitch slightly below pi/p to make sure that when drawing the sym version in FEMM, the magnet side didn't collide with the sym line. Now SlotM11 forbid explicitly Wmag=pi/p and SlotM18 only requires Hmag. The BC are handled directly in LamSlotMag.build_geometry which is not a perfect solution. If one day we have another case of BC on active surface, a more genetical method could be introduced.
This PR also reorganize the GUI tests for the SlotMX widgets and remove the scaling of the images:
Best regards,
Pierre