Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CO] Merging DMatLib and DMatSetup + [CO] Loading missing files #487

Merged
merged 13 commits into from
Jan 24, 2022

Conversation

BonneelP
Copy link
Collaborator

@BonneelP BonneelP commented Jan 6, 2022

Hello all,

We are currently working to simplify/improve the material library widgets. As a first (important) step, we have merged DMatLib and DMatSetup into one widget:
Before:
image
image

Now:
image

So instead of opening a popup when editing/creating a new material everything is done directly in DMatLib which should be clearer for the user (since the material list is still visible on the side).

The buttons "Add to machine" and "Save in Library" were a source of confusion. Now when selecting a material in the Library a button "Edit in machine" is available and add a line in the corresponding table (still on the same widget so the consequence of clicking this button should be more clear).
For now the GUI doesn't allow any more to save a material from a machine into the Library. We could add this feature back with a dedicated button but it would add some complexity to the GUI. We think that we should encourage creating first a material in the Library before editing it in the machine.

When saving a machine/simulation in json folder mode, the machine file save the materials as mat_type: "M400-50A.json" as this file is supposed to be next to the machine. When sending a machine by email, it happens that the material are forgotten and it become impossible to open the machine file in the GUI. The class generator was modified to set a missing file to None (a log a error message) to enable the possibility to open the machine without its materials.

This PR also contains some miscellaneous bug correction/improvements:

  • Slot constraints in the GUI are cleaner
  • try catch were added to the plot in the GUI
  • the retro-compatibility now use the dedicated logger

Best Regards,
Pierre

@BonneelP BonneelP merged commit 5f2bf26 into Eomys:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant