[CO] Merging DMatLib and DMatSetup + [CO] Loading missing files #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
We are currently working to simplify/improve the material library widgets. As a first (important) step, we have merged DMatLib and DMatSetup into one widget:
Before:
Now:
So instead of opening a popup when editing/creating a new material everything is done directly in DMatLib which should be clearer for the user (since the material list is still visible on the side).
The buttons "Add to machine" and "Save in Library" were a source of confusion. Now when selecting a material in the Library a button "Edit in machine" is available and add a line in the corresponding table (still on the same widget so the consequence of clicking this button should be more clear).
For now the GUI doesn't allow any more to save a material from a machine into the Library. We could add this feature back with a dedicated button but it would add some complexity to the GUI. We think that we should encourage creating first a material in the Library before editing it in the machine.
When saving a machine/simulation in json folder mode, the machine file save the materials as mat_type: "M400-50A.json" as this file is supposed to be next to the machine. When sending a machine by email, it happens that the material are forgotten and it become impossible to open the machine file in the GUI. The class generator was modified to set a missing file to None (a log a error message) to enable the possibility to open the machine without its materials.
This PR also contains some miscellaneous bug correction/improvements:
Best Regards,
Pierre