[CO] Rework MeshSolution Tutorial #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endre points, and scalar product to ElementMat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
This PR extend the MeshSolution Tutorial to further details the properties/methods.
I have also added some docstring and comments in some files.
I would have one question : regarding pyleecan/Methods/Mesh/MeshMat/add_cell.py, we need to find the indice of the next cell to add. In the current method we use "max" on the indices matrix which can take time so I have replaced it with "get_cell_nb" which works only if no cell are removed. Is it a correct assumption or should I revert to the previous method ?
Best regards,
Pierre