Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize number #2406

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Localize number #2406

merged 3 commits into from
Oct 7, 2021

Conversation

hkvstore
Copy link
Contributor

Localize numbers in the calendar also.

@hkvstore hkvstore mentioned this pull request Sep 17, 2021
src/js/actions.ts Outdated Show resolved Hide resolved
src/js/actions.ts Outdated Show resolved Hide resolved
@hkvstore
Copy link
Contributor Author

hkvstore commented Sep 17, 2021

I just want to be consistent with original code which uses .getAttribute('data-value') in actions.ts:

const value = +currentTarget.getAttribute('data-value');

let hour = +currentTarget.getAttribute('data-value');

@Eonasdan Eonasdan changed the base branch from master to v6-next October 7, 2021 13:49
Eonasdan and others added 2 commits October 7, 2021 09:49
Co-authored-by: Lukas Juhrich <lukasjuhrich@users.noreply.github.com>
Co-authored-by: Lukas Juhrich <lukasjuhrich@users.noreply.github.com>
@Eonasdan Eonasdan merged commit bf89e94 into Eonasdan:v6-next Oct 7, 2021
@Eonasdan
Copy link
Owner

Eonasdan commented Oct 7, 2021

Thank you @hkvstore and @lukasjuhrich for contributing on this. I've merged to the 6-next branch that I'll probably be release this weekend. I also updated the other get attribute locations.

@hkvstore hkvstore deleted the localization branch December 24, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants