-
Notifications
You must be signed in to change notification settings - Fork 262
Add TCP+Relay detection event #485
Add TCP+Relay detection event #485
Conversation
…ceivedTimestamp,lastPacketSentTimestamp,priority,remoteCandidateId,transportId and writable
…l candidate is relayed over tcp
Frontend/library/src/PeerConnectionController/AggregatedStats.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments for changes around the specificity of the event, binding to it, and the general detection of the tcp/relay connection.
…ion to get the active candidate pair
…tc transport is tcp and the candidate type is relay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested some changes around how the stats are intercepted so that it works on each new connection, not just the first one.
Additionally, it appears the unit tests are now failing against your PR, please look into that too. |
…relying on a check
… variable instead of calling multiple times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested refactoring lambda into a named function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request for ambiguous this context change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about the remove listener case, you should revert it to using bind() as the arrow function syntax won't work for the remove case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Relevant components:
Problem statement:
There is currently no event emitted if the local candidate is relayed over TCP
this can happen if the local candidate is connected to a TURN server and the transport is TCP
This will degrade the stream quality severely
Solution
Stream quality severely degraded, local connection is relayed over TCP due to the local network environment.
messageDocumentation
To subscribe to the event