This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Bug Fix TCP Relay event to only be emitted once #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehb
approved these changes
Feb 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
The
WebRtcConnectedEventwas not getting removed once the check had completed successfully. Due to the_setupWebRtcTCPRelayDetectlosing context tothisSolution
Bind the
_setupWebRtcTCPRelayDetectfunction tothis.Documentation
Test Plan and Compatibility
Ensured the event is only raised once if the WebRTC connection was made with TURN and the transport set to TCP