Skip to content

[LatencyTest] Fixing a small issue with how path was setup previously. (#611) #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

[LatencyTest] Fixing a small issue with how path was setup previously. (#611) #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions SignallingWebServer/platform_scripts/bash/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ function setup_node() {

popd > /dev/null

# setup path with our possibly locally installed node
PATH="${SCRIPT_DIR}/node/bin:$PATH"

# navigate to project root
pushd "${SCRIPT_DIR}/../../.." > /dev/null

Expand All @@ -170,11 +173,6 @@ function setup_node() {
&& rm node.tar.xz
&& mv node-v*-*-* \"${SCRIPT_DIR}/node\""

if [ $? -eq 1 ]; then
# installed node, point PATH to it
PATH="${SCRIPT_DIR}/node/bin:$PATH"
fi

# if node_modules doesnt exist or the package-lock file is newer than node_modules, install deps
if [ ! -d node_modules ] || [ ../package-lock.json -nt node_modules ] || [ "$INSTALL_DEPS" == "1" ]; then
echo "Installing dependencies..."
Expand Down