-
Notifications
You must be signed in to change notification settings - Fork 165
Fix: Firefox connectivity issues caused by PR694 #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 39d76ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
If this turns out to be an issue because bundle master is no longer 0 we can get bundle master using something like:
Then we can just always add a candidate with that mid, the immediately after, add another candidate with whatever the real mid was. It is a little wasteful in terms of adding known failing ice candidates, but it should fix the issue. |
…d are stripped. (#709) (#710) * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (cherry picked from commit 7790838) * Patch bump lib-pixelstreamingfrontend-ue5.6 version Assume sdpMLineIndex is always 0 for bundle master media line to restore connectivity with Firefox after changes in PR#694. --------- Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711) (cherry picked from commit 7790838) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#712) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update signalling library readme, patch bump * Update readme for ui library, bump patch version * Update frontend docs, patch bump * Update common readme, patch bump --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Bump markdown link checker version for security patch #691 * Update link checker to permit 429 code from Github as valid * Update user-agent in link checker action to try prevent 403 forbidden on some sites * Update link checker to accept HTTP status 403 (forbidden) * Remove broken link about eslint * Modify README for mediasoup-sdp-bridge to remove broken link Updated README to reflect fork status and removed badges. * Update workflow triggers for markdown files in push and PR * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) * Bring 5.7 changes to master branch (docs + sdpMid fix) (#716) * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711) (cherry picked from commit 7790838) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#712) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update signalling library readme, patch bump * Update readme for ui library, bump patch version * Update frontend docs, patch bump * Update common readme, patch bump --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update copyright notice * Update copyright notice in CONTRIBUTING.md * Update copyright notice * Update copyright in frontend/readme.md * Delete .changeset/light-games-wonder.md --------- Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Relevant components:
Problem statement:
As a result of #694 sometimes Firefox was unable to connect. It would error with
uncaught (in promise) DOMException: Cannot set ICE candidate for level=<Nothing> mid=: No such transceiver.
Solution
This PR patches the previous fix by hard coding the
sdpMLineIndex
to0
which resolves the issue on Firefox and maintains working connectivity on the other browsers. This change means we assume:Both of these assumptions hold for all versions of Pixel Streaming 1 and 2 to date.
Documentation
N/A - This is very implementation specific, but this PR should serve as a good record.
Test Plan and Compatibility
Tested:
Chrome + AWS
Chrome + TailScale
Firefox + AWS
FireFox + TailScale
Safari + AWS
Safari + TailScale
All these combinations were able to stream correctly.