Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make embed_file paths relative to build dir instead of CWD #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marler8997
Copy link

@marler8997 marler8997 commented Aug 10, 2024

Currently metagen resolves embed_file paths relative to CWD. This differs from how it finds mdesk files which searches for them relative to the build directory where the metagen.exe lives. This discrepancy causes metagen to produce unexpected results if it is invoked from another directory. I've solved this discrepancy by treating all embed_file paths relative to the build directory.

NOTE: you can reproduce this issue by running this command which will cause df_gfx.meta.h to lose all it's embedded file content build && cmd /c "cd src\os && ..\..\build\metagen"

Currently metagen resolves embed_file paths relative to CWD.  This differs
from how it finds mdesk files which searches for them relative to the
build directory where the metagen.exe lives.  This discrepancy causes
metagen to produce unexpected results if it is invoked from another
directory.  I've solved this discrepancy by treating all embed_file paths
relative to the build directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant