Fix issues with UTF-8 display and navigation #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alektron
force-pushed
the
FixUtf8Issues
branch
from
bd3d874 to
88c5300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs related to UTF-8.
The first bug was in UTF-8 decoding and prevented certain multi byte characters from getting added to the font atlas correctly.
This issue was first noticed when trying to type a german 'Ü' into the target's
Argumentsfield and only empty space showed up.This is exactly the same as #184.
Sorry for the duplication but the rest of this pull request only really makes sense with this change.
The second bug is not so much a bug but more the missing implementation for
UI_EventDeltaUnit_Char.It now properly adjusts the delta to correctly jump over multi byte character in both directions.
Without this fix e.g. the previously mentioned 'Ü' acted like two characters when trying to move the cursor.
There still seems to be outstanding issues with rendering multi byte characters where monospaced font is used. For example the watch window.