Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the new module such that nothing needs to be downloaded #20

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

JonasCir
Copy link
Collaborator

@JonasCir JonasCir commented Oct 7, 2022

Fixes #6

@POPPIN-FUMI We now have a proper new command.
PR features:

  1. No downloading of templates (you can remove the old Google storage now)
  2. The files we create are now stored as templates. We can easily tweak/improve them over time to our liking
  3. Generation of the migration is programmatically done through sea-orm-cli directly
  4. Integration testing has been become super convenient b/c of assert_directory_equality
  5. I cut down the files and content of the emitted to the bare minimum. I'm not a fan of feature-creep, if we notice that something is missing, we can simply add/improve it.

Please note that generation (which would be the next step after running zapp new) is currently broken. This is due to the fact that a) the code we generate is not compatible with the sea-orm version we are pinning and b) sea-orm is migration based, so we need to switch this (gone file an issue about that later).

@JonasCir JonasCir requested a review from POPPIN-FUMI October 7, 2022 18:45
Copy link
Collaborator

@POPPIN-FUMI POPPIN-FUMI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got much cleaner 🎉

@POPPIN-FUMI POPPIN-FUMI merged commit 96de579 into EpicsDAO:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there any way to include initial file in cargo package?
2 participants