Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make errors on uploads more user-friendly #570

Closed
jay-m-dev opened this issue Jan 27, 2023 · 2 comments
Closed

Make errors on uploads more user-friendly #570

jay-m-dev opened this issue Jan 27, 2023 · 2 comments
Assignees
Milestone

Comments

@jay-m-dev
Copy link
Contributor

We should have more specific errors so it's easier for users to fix the error and try uploading the dataset again. See attached screenshot for an example:
Aliro Error Uploading Data

@jay-m-dev
Copy link
Contributor Author

This error comes from validateDataset.py.

Related to this, uploading a dataset with a non-numeric data feature or target variable is allowed, but building experiments errors out with error "ValueError: Could not Convert String to Float: 'Iris Setosa'"

Steps to recreate: Upload the attached iris.csv where the "target" is a String. The file will be accepted, but experiments will fail.

We should reject any invalid datasets with user-friendly error messages.

Iris.csv

@jay-m-dev jay-m-dev added this to the Aliro/AliroEd v1.0.0 milestone Jan 27, 2023
HyunjunA added a commit that referenced this issue Jan 31, 2023
Update react and validateDataset.py to make errors on uploads more user-friendly
HyunjunA added a commit that referenced this issue Feb 1, 2023
Update validateDataset.py to show errors on uploads more user-friendly
HyunjunA added a commit to HyunjunA/Aliro that referenced this issue Feb 2, 2023
Update error message for each case in validateDataset.py
Update labApi.test.ts
Update react to show error message for each case
@jay-m-dev
Copy link
Contributor Author

Confirmed that the errors have been made more user friendly, here's an example:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants