Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data upload UI tweaks new #317

Merged
merged 8 commits into from
Apr 7, 2021
Merged

Data upload UI tweaks new #317

merged 8 commits into from
Apr 7, 2021

Conversation

mgstauffer
Copy link
Contributor

@mgstauffer mgstauffer commented Feb 26, 2021 •
edited
Loading 

- add Cancel button (hide file upload area after selecting a file)
- rename Feature Specification to Specification
- rename Dependent Feature to Target
- rename 'Submit' to Upload
- redo Ordinal ranking UI - opens in its own dialog
- Change text-based feature-specification modals to new quasi-modal method, and fix colors
- add auto-selection of target column during init
- add bug fix for text-based specification of categorical features

@mgstauffer
Dataset Upload UI changes
9a7afdf 
- add Cancel button
- rename Feature Specification to Specification
- rename Dependent Feature to Target
- rename 'Submit' to Upload

Former-commit-id: d4ed147
@mgstauffer
Finish ordinal ranking UI
20451d2 
Working well, container exapnds to scroll with large number of items
@mgstauffer
Change text-based feature-specification modals to new method and fix
012cd83 
colors
@mgstauffer
Add escape-key support for closing modals in File Upload window
44d48e1
@mgstauffer
File Upload - fix esc key behavior w/ error dialog; fix cancel file load
bb50a5a 
behavior
@mgstauffer
file upload - small UI changes - probably the final ones
86a3446 
dropdown styling, changed to fluid to make constant width
move info icon buttons
fix marging on filename header
@mgstauffer
FileUpload - add auto-selection of target column during init
aa640d1
@mgstauffer
Copy link
Contributor Author

@hjwilli I've pushed a new commit with the UI change we discussed to do before a review. So, it's ready for review now.

@mgstauffer
FileUpload - fix bug with textual specification of categorical features
6a1683b 
Was not properly clearing features of categorical type when they were
removed from text input
@mgstauffer
Copy link
Contributor Author

@hjwilli I've pushed a new commit with a bug fix for the file upload UI. I tacked it on to this branch and PR since it hasn't been merged yet.

@hjwilli hjwilli assigned hjwilli and unassigned hjwilli Apr 2, 2021
@hjwilli hjwilli self-requested a review April 7, 2021 17:34
hjwilli
hjwilli approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@hjwilli hjwilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

@hjwilli hjwilli merged commit 4f76b40 into master Apr 7, 2021
@hjwilli hjwilli deleted the DataUploadUiTweaksNew branch April 16, 2021 17:51
@mgstauffer mgstauffer mentioned this pull request Jun 16, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjwilli hjwilli hjwilli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgstauffer @hjwilli