File upload unit tests2 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Direct access tests mostly done for feature specification code. Working on tests for text-based feature specification.
Ordinal feature specification text input tests.
Needed for proper error handling in Github Actions NO Enzyme Snapshot for js_tests.sh
Remove the untested method of fine control via env vars. Move to separate branch to work on separately.
|
Merged per approval from Heather |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests should be finished now.
The issue with the enzyme snapshot inconsistency between local machine and github actions is resolved by running the local unit tests using docker-compose instead of via an attached process.
The issue with github actions not properly catching an error in unit tests is resolved by properly returning exit values in unit tests scripts.
This should finish #262